Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charts: add timezone support #1122

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Nov 8, 2019

What problem does this PR solve?

This PR adds timezone support for all charts, closes: #1123

For the tidb-cluster chart, we already have the timezone option(default UTC). If the user does not change it to a different value(for example: Aisa/Shanghai), all pods will not be recreated.
If the user changes it to other value(for example: Aisa/Shanghai), all the related pods (add a TZ env) will be recreated(rolling update).

Regard other charts, we don't have a timezone option in their values.yaml. We add the timezone option in this PR. Whether the user uses the old values.yaml or the new values.yaml, all the related pods (add a TZ env) will not be recreated(rolling update).

The related pods include pump, drainer, dicovery, monitor, scheduled backup, tidb-initializer, tikv-importer.

All images' time zone maintained by tidb-operator are UTC. You need to make sure that the time zone inside your images are UTC if you use your own images.

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

ACTION REQUIRED: 

This PR adds `timezone` support for [all charts](https://github.com/pingcap/tidb-operator/tree/master/charts).

For the `tidb-cluster` chart, we already have the `timezone` option(default `UTC`). If the user does not change it to a different value(for example: `Aisa/Shanghai`), all pods will not be recreated.
If the user changes it to other value(for example: `Aisa/Shanghai`), all the related pods (add a `TZ` env) will be recreated(rolling update).

Regard other charts, we don't have a `timezone` option in their `values.yaml`. We add the `timezone` option in this PR. Whether the user uses the old `values.yaml` or the new `values.yaml`, all the related pods (add a `TZ` env) will not be recreated(rolling update).

The related pods include `pump`, `drainer`, `dicovery`, `monitor`, `scheduled backup`, `tidb-initializer`, `tikv-importer`.

All images' time zone maintained by `tidb-operator` are `UTC`. You need to make sure that the time zone inside your images are `UTC` if you use your own images.

@weekface weekface changed the title add timezone support [DNM] add timezone support Nov 8, 2019
@weekface
Copy link
Contributor Author

weekface commented Nov 8, 2019

/run-e2e-in-kind

@weekface weekface changed the title [DNM] add timezone support Add timezone support Nov 8, 2019
@weekface weekface changed the title Add timezone support charts: Add timezone support Nov 8, 2019
@weekface weekface changed the title charts: Add timezone support charts: add timezone support Nov 8, 2019
@weekface
Copy link
Contributor Author

weekface commented Nov 8, 2019

/run-e2e-in-kind

@weekface weekface added the status/PTAL PR needs to be reviewed label Nov 8, 2019
Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit 26a6ce6 into pingcap:master Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

cherry pick to release-1.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: add timezone support to all charts
5 participants