-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
charts: add timezone support #1122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-e2e-in-kind |
/run-e2e-in-kind |
onlymellb
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DanielZhangQD
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-1.0 failed |
weekface
added a commit
to weekface/tidb-operator
that referenced
this pull request
Nov 11, 2019
weekface
added a commit
that referenced
this pull request
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR adds
timezone
support for all charts, closes: #1123For the
tidb-cluster
chart, we already have thetimezone
option(defaultUTC
). If the user does not change it to a different value(for example:Aisa/Shanghai
), all pods will not be recreated.If the user changes it to other value(for example:
Aisa/Shanghai
), all the related pods (add aTZ
env) will be recreated(rolling update).Regard other charts, we don't have a
timezone
option in theirvalues.yaml
. We add thetimezone
option in this PR. Whether the user uses the oldvalues.yaml
or the newvalues.yaml
, all the related pods (add aTZ
env) will not be recreated(rolling update).The related pods include
pump
,drainer
,dicovery
,monitor
,scheduled backup
,tidb-initializer
,tikv-importer
.All images' time zone maintained by
tidb-operator
areUTC
. You need to make sure that the time zone inside your images areUTC
if you use your own images.What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: