-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix e2e nil point dereference #1221
Merged
onlymellb
merged 5 commits into
pingcap:master
from
onlymellb:fix-e2e-nil-point-dereference
Nov 25, 2019
Merged
fix e2e nil point dereference #1221
onlymellb
merged 5 commits into
pingcap:master
from
onlymellb:fix-e2e-nil-point-dereference
Nov 25, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-e2e-tests |
weekface
previously approved these changes
Nov 22, 2019
cofyc
previously approved these changes
Nov 22, 2019
/run-e2e-tests |
/run-e2e-tests |
aylei
approved these changes
Nov 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e-tests |
weekface
approved these changes
Nov 25, 2019
aylei
pushed a commit
that referenced
this pull request
Nov 26, 2019
* fix e2e nil point dereference * fix CI * fix the judgment condition of ci script
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix e2e nil point dereference when get pod from apiserver failed.
https://internal.pingcap.net/idc-jenkins/view/tidb-operator/job/build_tidb_operator_master_kind/168/console
Fix reclaim PV failed, this failed job come from PR v1.0.4 release #1210
https://internal.pingcap.net/idc-jenkins/view/tidb-operator/job/operator_ghpr_e2e_test_kind/1114/console
Fix the judgment condition of ci script, make not upload build artifact when running PR
Check List
Tests
Code changes
Does this PR introduce a user-facing change?: