CI: Running on TiDB Operator Nodes. #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
changed the title
cofyc
force-pushed
the
running-on-tidb-operator-nodes
branch
from
aa06abe to
80b9699
Compare
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
cofyc
commented
Feb 7, 2020
| @@ -161,6 +173,8 @@ def call(BUILD_BRANCH, CREDENTIALS_ID, CODECOV_CREDENTIALS_ID) { | |||
| container("golang") { | |||
| def WORKSPACE = pwd() | |||
| dir("${PROJECT_DIR}") { | |||
| deleteDir() | |||
There was a problem hiding this comment.
because we reuse build_go1130_memvolume nodes to build, previous files of other jobs must be deleted first
failure logs on this PR: https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/operator_ghpr_e2e_test_kind/detail/operator_ghpr_e2e_test_kind/2667/pipeline/39
2020-02-07T08:38:48.004Z] go vet check
[2020-02-07T08:38:49.901Z] # github.com/pingcap/tidb-operator/pkg/client/listers/pingcap/v1alpha1
[2020-02-07T08:38:49.901Z] pkg/client/listers/pingcap/v1alpha1/tidbclusterautoscaler.go:28:41: undefined: v1alpha1.TidbClusterAutoScaler
[2020-02-07T08:38:49.901Z] pkg/client/listers/pingcap/v1alpha1/tidbclusterautoscaler.go:31:2: undefined: TidbClusterAutoScalerListerExpansion
[2020-02-07T08:38:49.901Z] pkg/client/listers/pingcap/v1alpha1/tidbclusterautoscaler.go:45:78: undefined: v1alpha1.TidbClusterAutoScaler
[2020-02-07T08:38:49.901Z] pkg/client/listers/pingcap/v1alpha1/tidbclusterautoscaler.go:60:41: undefined: v1alpha1.TidbClusterAutoScaler
[2020-02-07T08:38:49.901Z] pkg/client/listers/pingcap/v1alpha1/tidbclusterautoscaler.go:62:21: undefined: v1alpha1.TidbClusterAutoScaler
[2020-02-07T08:38:49.901Z] pkg/client/listers/pingcap/v1alpha1/tidbclusterautoscaler.go:63:2: undefined: TidbClusterAutoScalerNamespaceListerExpansion
[2020-02-07T08:38:49.901Z] pkg/client/listers/pingcap/v1alpha1/tidbclusterautoscaler.go:74:86: undefined: v1alpha1.TidbClusterAutoScaler
[2020-02-07T08:38:49.901Z] pkg/client/listers/pingcap/v1alpha1/tidbclusterautoscaler.go:82:66: undefined: v1alpha1.TidbClusterAutoScaler
|
/run-e2e-tests |
cofyc
force-pushed
the
running-on-tidb-operator-nodes
branch
from
da937db to
9eab3d9
Compare
On these nodes, we configured 'cgroup.memory=nokmem' to avoid issues in CentOS 7.6. pingcap#1603 (comment) Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
cofyc
force-pushed
the
running-on-tidb-operator-nodes
branch
from
9eab3d9 to
e422fce
Compare
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
cofyc
commented
Feb 7, 2020
| if errors.IsNotFound(err) { | ||
| // ignore not found error (pod is deleted and recreated again in restarting) | ||
| return false, nil | ||
| } |
cofyc
commented
Feb 8, 2020
| @@ -22,7 +22,7 @@ source $ROOT/hack/lib.sh | |||
|
|
|||
| hack::ensure_terraform | |||
|
|
|||
| terraform_modules=$(find ${ROOT}/deploy -not -path '*/\.*' -type f -name variables.tf | xargs -I{} -n1 dirname {}) | |||
| terraform_modules=$(find ${ROOT}/deploy -mindepth 1 -maxdepth 1 -type d -a -not -name 'modules') | |||
There was a problem hiding this comment.
modules in deploy/modules are referenced by aliyun/gcp/aws, no need to check
Yisaer
approved these changes
Feb 8, 2020
|
cherry pick to release-1.1 in PR #1660 |
Yisaer
pushed a commit
that referenced
this pull request
Feb 9, 2020
* Running on TiDB Operator Nodes. On these nodes, we configured 'cgroup.memory=nokmem' to avoid issues in CentOS 7.6. #1603 (comment) Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com> * clear previous files Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com> * check gcp/aliyun/aws modules only Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com> * use operator: Exists Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com> * ignore not found error Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com> Co-authored-by: Yecheng Fu <cofyc.jackson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yecheng Fu fuyecheng@pingcap.com
What problem does this PR solve?
On these nodes, we configured 'cgroup.memory=nokmem' to avoid issues in
CentOS 7.6.
#1603 (comment)
it also fixes #1539
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: