Flexible tidb initializer job with secret set outside of helm #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregwebs
reviewed
Feb 26, 2019
| @@ -177,8 +180,9 @@ tidb: | |||
| # cloud.google.com/load-balancer-type: Internal | |||
|
|
|||
| # mysqlClient is used to set password for TiDB | |||
| # it must has Python MySQL client installed | |||
There was a problem hiding this comment.
Having this image be configurable may not be useful anymore. But we could rename it to pythonMysqlClient.
There was a problem hiding this comment.
It's still need to be configured especially when dockerhub is unavailable.
|
This looks great! I will try it out. In #274 I also mentioned secrets used in backup. |
gregwebs
reviewed
Feb 26, 2019
gregwebs
reviewed
Feb 26, 2019
|
/run-e2e-tests |
gregwebs
reviewed
Feb 27, 2019
|
/run-e2e-tests |
3 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
approved these changes
Feb 28, 2019
|
/run-e2e-tests |
gregwebs
approved these changes
Mar 5, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #274. It uses secret created outside of helm to avoid storing password in ConfigMap. And it also enables flexible initialization SQL statement.