Ensure SLOW_LOG_FILE env variable is always set #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
|
/run-e2e-tests |
|
I think you should move #297 codes to this PR, or we can't confirm this PR can work as expected without the e2e tests. |
weekface
reviewed
Mar 6, 2019
Signed-off-by: Aylei <rayingecho@gmail.com>
|
/run-e2e-tests |
2 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
|
I rebuilt the dind env. You should rerun the e2e after this job is completed: https://internal.pingcap.net/jenkins/job/rebuild_k8s_dind_test_env/82/ |
|
/run-e2e-tests |
weekface
approved these changes
Mar 6, 2019
|
ping @tennix @xiaojingchen |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* cdc document * Update zh/deploy-ticdc.md Co-authored-by: Ran <huangran@pingcap.com> * address comments * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #295
Signed-off-by: Aylei rayingecho@gmail.com