stability: add scale & upgrade case functions #309
Conversation
|
|
| return nil | ||
| } | ||
|
|
||
| func (oa *operatorActions) UpgradeTidbCluster(info *TidbClusterInfo) error { |
There was a problem hiding this comment.
change to UpgradeTidbClusterTo(info *TidbClusterInfo,version string)
There was a problem hiding this comment.
But how to upgrade only one component (eg. just upgrade tidb) ?
|
Add it the the main func to ensure it works as expected. |
| return "/charts/" + tag + "/" + name | ||
| } | ||
|
|
||
| func (oa *operatorActions) ScaleTidbCluster(info *TidbClusterInfo) error { |
There was a problem hiding this comment.
change to ScaleTidbClusterTo(info *TidbClusterInfo,pdReplicas int,tikvReplicas int,tidbReplicas int) is more reasonable
|
each test case consists of two parts, triggering the event first, and then checking for success.the scale and upgrade method have not contained checking logic. |
I'm working on it, however check for an upgrade often timeout.
I thought |
| perror(oa.DeployTidbCluster(clusterInfo)) | ||
| perror(oa.CheckTidbClusterStatus(clusterInfo)) | ||
|
|
||
| clusterInfo = clusterInfo.ScaleTiDB(3) |
There was a problem hiding this comment.
We should scale in and scale out all the components: pd, tikv and tidb.
There was a problem hiding this comment.
Yes, you can do this in another PR.
I'm already working on it, also, I'm trying to port ddl test as a workload. I'll commit these works in the next few PRs. |
|
Great! |
* impl scale & upgrade cases
I just implement two case functions for
OperationActions, PTAL.