use release name as default clusterName #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
gregwebs
previously approved these changes
Mar 27, 2019
weekface
reviewed
Mar 28, 2019
|
|
||
| {{- define "cluster.name" -}} | ||
| {{- default .Release.Name .Values.clusterName }} | ||
| {{- end -}} |
There was a problem hiding this comment.
No newline at the end of file
|
/run-e2e-tests |
|
Add an e2e test spec to cover this? |
|
/rebuild |
3 similar comments
|
/rebuild |
|
/rebuild |
|
/rebuild |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
weekface
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making users specify two names for a cluster is verbose and error-prone, if users install two clusters in the same name without specifying the
clusterNameexplicitly, then the second cluster would fail to create because of duplicatedclusterName.This PR uses release name as default
clusterName, but also allow users to specifyclusterNameexplicitly in order to make the pod name short if the release name is auto-generated long name. For example, if the release name uses UUID, then specifying a shorterclusterNameexplicitly would make the resource name more readable usingkubectl.