-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CLI #357
Build CLI #357
Conversation
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
/run-e2e-tests |
/build |
1 similar comment
/build |
Signed-off-by: Aylei <rayingecho@gmail.com>
please fix ci |
This a draft PR and I'm still working on this, hopefully I will fix it before tomorrow |
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
Signed-off-by: Aylei <rayingecho@gmail.com>
/run-e2e-tests |
3 similar comments
/run-e2e-tests |
/run-e2e-tests |
/run-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use tkc as a plugin with kubectl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a very early version of our CLI tool, for better reviewing experience, debug related functionalities are moved to next PR.
Some decisions are vague and supposed to be changed later on, namely, the CLI tool is currently alpha, however, I think the basic code skeleton is almost fine.
Moreover, this PR updates kubernetes related dependencies to 1.12.5
PTAL @tennix @xiaojingchen @weekface @shuijing198799 @gregwebs
Some examples in my local machine: