Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extraLabels variable in tidb-cluster chart #373

Merged
merged 2 commits into from
Apr 9, 2019
Merged

add extraLabels variable in tidb-cluster chart #373

merged 2 commits into from
Apr 9, 2019

Conversation

LinuxGit
Copy link
Contributor

@LinuxGit LinuxGit commented Apr 8, 2019 •
edited by tennix
Loading

  • add additional custom TidbCluster labels

@LinuxGit LinuxGit requested review from tennix and onlymellb April 8, 2019 13:52
@LinuxGit
Copy link
Contributor Author

LinuxGit commented Apr 8, 2019

/run-e2e-tests

tennix
tennix approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor

weekface commented Apr 9, 2019

/run-e2e-tests

onlymellb
onlymellb approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@onlymellb onlymellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaojingchen
Copy link
Contributor

/run-e2e-tests

@LinuxGit LinuxGit merged commit 6378a2d into pingcap:master Apr 9, 2019
@LinuxGit LinuxGit deleted the Louis/extra-labels branch April 9, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlymellb onlymellb onlymellb approved these changes

@tennix tennix tennix approved these changes

@xiaojingchen xiaojingchen xiaojingchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LinuxGit @weekface @xiaojingchen @tennix @onlymellb