use ioutil.TempDir() create charts and operator repo's directories
#405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
reviewed
Apr 17, 2019
| return nil, err | ||
| } | ||
| cfg.ChartDir = chartDir | ||
| return cfg, nil |
There was a problem hiding this comment.
Where is the place to clean these temporary directories?
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
approved these changes
Apr 18, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Co-authored-by: Caitin <34535727+CaitinChen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stability test needs some dirs to store charts files and tidb-operator repo, these dirs is useful only during case running, but if user run stability test on local these directories may require authorization to access.
this pr use
ioutil.TempDir()to replace the directories which were specified in the code.