Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of kind to v0.11.1 and version of ubuntu to 20.04 (#4063) #4066

Merged
merged 4 commits into from
Jul 9, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 8, 2021

cherry-pick #4063 to release-1.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb-operator repo:
git pr https://github.com/pingcap/tidb-operator/pull/4066

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb-operator.git pr/4066:release-1.1-74ccda087708

What problem does this PR solve?

Close #4059

Ref kubernetes-sigs/kind#2241

Remove test shell tests/examples/003-basic-cn.sh.

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

@KanShiori you're already a collaborator in bot's repo.

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-serial

2 similar comments
@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-serial

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-serial

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@79ad44b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5858c67 differs from pull request most recent head 4644937. Consider uploading reports for the commit 4644937 to get more accurate results

@@              Coverage Diff               @@
##             release-1.1    #4066   +/-   ##
==============================================
  Coverage               ?   52.57%           
==============================================
  Files                  ?      161           
  Lines                  ?    15633           
  Branches               ?        0           
==============================================
  Hits                   ?     8219           
  Misses                 ?     6631           
  Partials               ?      783           
Flag Coverage Δ
unittest 52.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6771e71

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1603eba into pingcap:release-1.1 Jul 9, 2021
@DanielZhangQD DanielZhangQD modified the milestones: v1.1.13, v1.1.14 Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants