Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of kind to v0.11.1 and version of ubuntu to 20.04 (#4063) #4067

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 8, 2021

cherry-pick #4063 to release-1.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb-operator repo:
git pr https://github.com/pingcap/tidb-operator/pull/4067

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb-operator.git pr/4067:release-1.2-74ccda087708

What problem does this PR solve?

Close #4059

Ref kubernetes-sigs/kind#2241

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

@KanShiori you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot requested a review from july2993 July 8, 2021 15:22
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #4067 (bc936d2) into release-1.2 (bb24123) will increase coverage by 0.51%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release-1.2    #4067      +/-   ##
===============================================
+ Coverage        70.36%   70.87%   +0.51%     
===============================================
  Files              182      182              
  Lines            19374    19374              
===============================================
+ Hits             13632    13731      +99     
+ Misses            4623     4507     -116     
- Partials          1119     1136      +17     
Flag Coverage Δ
e2e 57.14% <ø> (+1.87%) ⬆️
unittest 61.14% <ø> (ø)

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@DanielZhangQD: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@KanShiori
Copy link
Collaborator

/test pull-e2e-kind

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@DanielZhangQD: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@csuzhangxc
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: bc936d2

@ti-chi-bot ti-chi-bot merged commit 2dd7e4b into pingcap:release-1.2 Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants