Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and speed up local DinD e2e testing #407

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Fix and speed up local DinD e2e testing #407

merged 1 commit into from
Apr 24, 2019

Conversation

cofyc
Copy link
Contributor

@cofyc cofyc commented Apr 18, 2019 •
edited
Loading

  • allocate30 (3x10) PVs by default (at most we need 3 * (5 + 5) PVs)
  • reduce request resources of e2e pods, make it possible to run on
    low resources machine
    • IIUC, we don't care about this in e2e testing
  • smaller poll interval to speed up e2e
    • checking against API is low overhead, smaller interval speeds up a lot
    • suggested by @xiaojingchen, only the e2e poll interval is changed

@cofyc cofyc changed the title Some improvements in local DinD e2e testing WIP: Some improvements in local DinD e2e testing Apr 18, 2019
@cofyc
Copy link
Contributor Author

cofyc commented Apr 18, 2019

/run-e2e-tests

@cofyc
Copy link
Contributor Author

cofyc commented Apr 18, 2019

/run-e2e-tests

@cofyc cofyc changed the title WIP: Some improvements in local DinD e2e testing Speed up local DinD e2e testing Apr 18, 2019
@cofyc
Copy link
Contributor Author

cofyc commented Apr 18, 2019

/run-e2e-tests

@cofyc cofyc changed the title Speed up local DinD e2e testing Fix and speed up local DinD e2e testing Apr 18, 2019
@cofyc
Copy link
Contributor Author

cofyc commented Apr 19, 2019

/run-e2e-tests

weekface
weekface previously approved these changes Apr 19, 2019
View reviewed changes
@cofyc cofyc requested a review from xiaojingchen April 19, 2019 05:34
@cofyc
- allocate 24 PVs by default (after 2 clusters are scaled to
c78d36d 
TiKV=5,PD=5, we need at least 20 PVs)
- reduce request resources of e2e pods, make it possible to run on
low resources machine
- smaller poll interval to speed up e2e
@cofyc
Copy link
Contributor Author

cofyc commented Apr 19, 2019

pushed a new commit to resolve conflicts, @weekface @xiaojingchen PTAL.

@cofyc
Copy link
Contributor Author

cofyc commented Apr 19, 2019

/run-e2e-tests

@cofyc
Copy link
Contributor Author

cofyc commented Apr 24, 2019

/run-e2e-tests

@cofyc cofyc merged commit d8e43e0 into pingcap:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaojingchen xiaojingchen xiaojingchen approved these changes

@weekface weekface weekface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cofyc @weekface @xiaojingchen