Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell completion for tkctl #431

Merged
merged 3 commits into from
Apr 29, 2019

Conversation

onlymellb
Copy link
Contributor

What problem does this PR solve?

add shell completion for the specified shell (bash or zsh) for tkctl CLI

What is changed and how it works?

just add a completion subcommand without changing the existing logic,use it like any other command.

Check List

Tests

  • Manual test

Code changes

  • Has Go code change

Side effects

  • No

@onlymellb onlymellb requested a review from aylei April 26, 2019 12:09
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Could you please update the groovy ci accordingly?

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiaojingchen xiaojingchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@onlymellb onlymellb merged commit 38cd8fd into pingcap:master Apr 29, 2019
@onlymellb onlymellb deleted the shell-completion-for-tkctl branch April 29, 2019 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants