Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds instructions to access Grafana in GKE tutorial #448

Merged
merged 4 commits into from
May 3, 2019

Conversation

jlerche
Copy link
Contributor

@jlerche jlerche commented May 1, 2019

What problem does this PR solve?

#404

What is changed and how it works?

Adds instruction in the GKE tutorial to access Grafana dashboard

Check List

Tests

  • No code

Code changes

  • Has documents change

Side effects

Related changes

@CLAassistant
Copy link

CLAassistant commented May 1, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@gregwebs gregwebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix
Copy link
Member

tennix commented May 2, 2019

I think it's better to use a load balancer for the tutorial, so new users can easily access it via a public DNS name.
Adding extra value: monitor.grafana.service.type=LoadBalancer when installing TiDB cluster.

helm install ./charts/tidb-cluster -n demo --namespace=tidb --set pd.storageClassName=pd-ssd,tikv.storageClassName=pd-ssd,monitor.grafana.service.type=LoadBalancer

And then get grafana service external IP: kubectl get svc -n tidb demo-grafana

@gregwebs
Copy link
Contributor

gregwebs commented May 2, 2019

@tennix that will create additional security concerns that I think we should avoid getting into during the tutorial. But your comment would make sense to add to the user guide.

@gregwebs
Copy link
Contributor

gregwebs commented May 3, 2019

We can merge this now and keep improving it as needed.

@gregwebs gregwebs merged commit b9ec5a2 into pingcap:master May 3, 2019
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants