-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds instructions to access Grafana in GKE tutorial #448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it's better to use a load balancer for the tutorial, so new users can easily access it via a public DNS name. helm install ./charts/tidb-cluster -n demo --namespace=tidb --set pd.storageClassName=pd-ssd,tikv.storageClassName=pd-ssd,monitor.grafana.service.type=LoadBalancer And then get grafana service external IP: |
@tennix that will create additional security concerns that I think we should avoid getting into during the tutorial. But your comment would make sense to add to the user guide. |
We can merge this now and keep improving it as needed. |
Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
What problem does this PR solve?
#404
What is changed and how it works?
Adds instruction in the GKE tutorial to access Grafana dashboard
Check List
Tests
Code changes
Side effects
Related changes