Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version command for tkctl #456

Merged
merged 7 commits into from
May 8, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/tkctl/cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ package cmd

import (
"flag"
"github.com/pingcap/tidb-operator/pkg/tkctl/cmd/version"
"io"

"github.com/pingcap/tidb-operator/pkg/tkctl/cmd/completion"
Expand Down Expand Up @@ -67,6 +68,7 @@ func NewTkcCommand(streams genericclioptions.IOStreams) *cobra.Command {
get.NewCmdGet(tkcContext, streams),
info.NewCmdInfo(tkcContext, streams),
use.NewCmdUse(tkcContext, streams),
version.NewCmdVersion(tkcContext, streams.Out),
},
},
{
Expand Down
111 changes: 111 additions & 0 deletions pkg/tkctl/cmd/version/version.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
// Copyright 2019. PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// See the License for the specific language governing permissions and
// limitations under the License.

package version

import (
"fmt"
"github.com/pingcap/tidb-operator/pkg/tkctl/config"
"github.com/pingcap/tidb-operator/version"
"github.com/spf13/cobra"
"io"
"k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
"k8s.io/kubernetes/pkg/apis/core"
cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
)

const (
versionExample = `
# Print the cli version and tidb operator version
tkctl version
`
)

type VersionOptions struct {
io.Writer
}

func NewCmdVersion(tkcContext *config.TkcContext, out io.Writer) *cobra.Command {
options := &VersionOptions{
Writer: out,
}
cmd := &cobra.Command{
Use: "version",
Short: "Print the client & server version",
Example : versionExample,
Run: func(_ *cobra.Command, _ []string) {
cmdutil.CheckErr(options.runVersion(tkcContext))
},
}
aylei marked this conversation as resolved.
Show resolved Hide resolved

return cmd
}

func (o *VersionOptions) runVersion(tkcContext *config.TkcContext) error {
restConfig, err := tkcContext.ToRESTConfig()
if err != nil {
return err
}
kubeCli, err := kubernetes.NewForConfig(restConfig)
if err != nil {
return err
}

clientVersion := version.Get()

controllers, err := kubeCli.AppsV1().
Deployments(core.NamespaceAll).
List(v1.ListOptions{
LabelSelector: "app.kubernetes.io/component=controller-manager,app.kubernetes.io/instance=tidb-operator",
aylei marked this conversation as resolved.
Show resolved Hide resolved
})
if err != nil {
return err
}
schedulers, err := kubeCli.AppsV1().
Deployments(core.NamespaceAll).
List(v1.ListOptions{
LabelSelector: "app.kubernetes.io/component=scheduler,app.kubernetes.io/instance=tidb-operator",
aylei marked this conversation as resolved.
Show resolved Hide resolved
})
if err != nil {
return nil
}

fmt.Fprintf(o, "Client Version: %s\n", clientVersion.GitVersion)
aylei marked this conversation as resolved.
Show resolved Hide resolved

// TODO: add version endpoint in tidb-controller-manager
// There's no version endpoint of tidb-controller-manager and tidb-scheduler, use image instead
if len(controllers.Items) == 0 {
fmt.Fprintf(o, "No TiDB Controller Manager found, please install one first\n")
} else if len(controllers.Items) == 1 {
fmt.Fprintf(o, "TiDB Controller Manager Version: %s\n", controllers.Items[0].Spec.Template.Spec.Containers[0].Image)
} else {
fmt.Fprintf(o, "TiDB Controller Manager Versions:\n")
for _, item := range controllers.Items {
fmt.Fprintf(o, "\t%s: %s\n", item.Name, item.Spec.Template.Spec.Containers[0].Image)
}
}
if len(schedulers.Items) == 0 {
fmt.Fprintf(o, "No TiDB Scheduler found, please install one first\n")
} else if len(schedulers.Items) == 1 {
fmt.Fprintf(o, "TiDB Scheduler Version: %s\n", schedulers.Items[0].Spec.Template.Spec.Containers[0].Image)
} else {
// warn for multiple scheduler
fmt.Fprintf(o, "WARN: more than one TiDB Scheduler instance found, this is un-supported and may lead to un-specified behavior:\n")
aylei marked this conversation as resolved.
Show resolved Hide resolved
for _, item := range schedulers.Items {
fmt.Fprintf(o, "\t%s\n", item.Name)
}
}

return nil
}