Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binlog problem on large scale #460

Merged
merged 6 commits into from
May 9, 2019

Conversation

weekface
Copy link
Contributor

@weekface weekface commented May 7, 2019

What problem does this PR solve?

  • update drainer config document
  • increase tidb-controller-manager and tidb-scheduler replicas to 2
  • update grafana query
  • increase drainer workerCount
  • move binlog above scheduled backup

What is changed and how it works?

Check List

Tests

  • E2E test
  • Stability test

Code changes

  • Has Go code change

Side effects

Related changes

* increase tidb-controller-manager and tidb-scheduler replicas to 2
* update grafana query
* increase drainer workerCount
* move binlog above scheduled backup
@weekface
Copy link
Contributor Author

weekface commented May 7, 2019

/run-e2e-tests

@weekface weekface force-pushed the increase-drainer-worker-count branch from 6bd2d22 to f8a2a48 Compare May 7, 2019 09:35
@weekface
Copy link
Contributor Author

weekface commented May 7, 2019

/run-e2e-tests

@weekface
Copy link
Contributor Author

weekface commented May 7, 2019

/run-e2e-tests

@shuijing198799
Copy link
Contributor

LGTM

@weekface weekface marked this pull request as ready for review May 8, 2019 02:59
@weekface
Copy link
Contributor Author

weekface commented May 8, 2019

/run-e2e-tests

@weekface
Copy link
Contributor Author

weekface commented May 8, 2019

/run-e2e-tests

1 similar comment
@weekface
Copy link
Contributor Author

weekface commented May 9, 2019

/run-e2e-tests

@weekface weekface merged commit 4401e27 into pingcap:master May 9, 2019
@weekface weekface deleted the increase-drainer-worker-count branch May 9, 2019 00:36
yahonda pushed a commit that referenced this pull request Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants