Fix bug use shareinformer without copy #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
|
All related logic that contains the SetLastAppliedConfigAnnotation function needs to be modified |
shuijing198799
changed the title
weekface
reviewed
May 7, 2019
| @@ -131,7 +131,7 @@ func (tmm *tidbMemberManager) syncTiDBStatefulSetForTidbCluster(tc *v1alpha1.Tid | |||
| tcName := tc.GetName() | |||
|
|
|||
| newTiDBSet := tmm.getNewTiDBSetForTidbCluster(tc) | |||
| oldTiDBSet, err := tmm.setLister.StatefulSets(ns).Get(controller.TiDBMemberName(tcName)) | |||
| oldTiDBSetTemp, err := tmm.setLister.StatefulSets(ns).Get(controller.TiDBMemberName(tcName)) | |||
There was a problem hiding this comment.
These two places need to be modified:
|
/run-e2e-tests |
weekface
approved these changes
May 8, 2019
shuijing198799
added a commit
to shuijing198799/tidb-operator
that referenced
this pull request
May 9, 2019
* use shareinformer without copy * fix bug use shareinformer without copy in kv pd and svc add webhook Add version command for tkctl (pingcap#456) * Add version command for tkctl Signed-off-by: Aylei <rayingecho@gmail.com> Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link modify code and add cli add tools code and modify code Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link add tools code and modify code use shareinformer without copy fix bug use shareinformer without copy in kv pd and svc add webhook Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link modify code and add cli add tools code and modify code Add tkctl user manual (pingcap#452) * Add basic documents for CLI tool Signed-off-by: Aylei <rayingecho@gmail.com> * Add TOC for manual Signed-off-by: Aylei <rayingecho@gmail.com> * Document about installation and shell completion Signed-off-by: Aylei <rayingecho@gmail.com> * Address review comments * Fix toc anchor link modify code and add cli add tools code and modify code
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* en: fix the "Debugging DNS Resolution" link * en: update a link
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Because the data in shareinformer is modified instead of using copy,，When the TiDB statefulset rolling upgrade process is interrupted, it will not be retried.
What is changed and how it works?
use copy data instead.
Tests
Code changes
Side effects