support the affinity feature of k8s which define the rule of assigning pods to nodes #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-test |
…hen/tidb-operator into set-affinity-direactly
|
/run-e2e-test |
xiaojingchen
changed the title
|
/run-e2e-test |
…hen/tidb-operator into set-affinity-direactly
weekface
reviewed
May 15, 2019
charts/tidb-cluster/values.yaml
Outdated
| # podAffinityTerm: | ||
| # labelSelector: | ||
| # matchLabels: | ||
| # app.kubernetes.io/instance: <cluster.name> |
There was a problem hiding this comment.
Suggested change
| # app.kubernetes.io/instance: <cluster.name> | |
| # app.kubernetes.io/instance: <helm release name> |
?
| # region: cn-bj1 | ||
| # Tolerations are applied to pods, and allow pods to schedule onto nodes with matching taints. | ||
| # refer to https://kubernetes.io/docs/concepts/configuration/taint-and-toleration | ||
|
|
There was a problem hiding this comment.
we should add a key:
locationLabels:
- region
- zone
- rack
- host
There was a problem hiding this comment.
right，that will be added in other pr
There was a problem hiding this comment.
open an issue to track it?
Co-Authored-By: weekface <weekface@gmail.com>
|
/run-e2e-test |
|
/run-e2e-test |
weekface
reviewed
May 16, 2019
docs/operation-guide.md
Outdated
|
|
||
| * CPU & Memory | ||
|
|
||
| The default deployment doesn't set CPU and memory requests or limits for any of the pods, these settings can make TiDB cluster run on a small Kubernetes cluster like DinD or the default GKE cluster for testing. But for production deployment, you would likely to adjust the cpu, memory and storage resources according to the [recommendations](https://github.com/pingcap/docs/blob/master/op-guide/recommendation.md). |
There was a problem hiding this comment.
https://github.com/pingcap/docs/blob/master/op-guide/recommendation.md
this link is broken.
Co-Authored-By: weekface <weekface@gmail.com>
Co-Authored-By: weekface <weekface@gmail.com>
Co-Authored-By: weekface <weekface@gmail.com>
Co-Authored-By: weekface <weekface@gmail.com>
Co-Authored-By: weekface <weekface@gmail.com>
Co-Authored-By: weekface <weekface@gmail.com>
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
|
/run-e2e-test |
weekface
reviewed
May 20, 2019
|
This is a breaking change. You should add these to
|
|
/run-e2e-test |
1 similar comment
|
/run-e2e-test |
|
|
-> |
cofyc
previously approved these changes
May 21, 2019
|
@cofyc |
|
/run-e2e-tests |
weekface
previously approved these changes
May 21, 2019
aylei
previously approved these changes
May 21, 2019
| * CPU & Memory | ||
|
|
||
| The default deployment doesn't set CPU and memory requests or limits for any of the pods, these settings can make TiDB cluster run on a small Kubernetes cluster like DinD or the default GKE cluster for testing. But for production deployment, you would likely to adjust the cpu, memory and storage resources according to the [recommendations](https://pingcap.com/docs/dev/how-to/deploy/hardware-recommendations/#software-and-hardware-recommendations). | ||
| The resource limits should be equal or bigger than the resource requests, it is suggested to set limit and request equal to get [`Guaranteed` QoS]( https://kubernetes.io/docs/tasks/configure-pod-container/quality-service-pod/#create-a-pod-that-gets-assigned-a-qos-class-of-guaranteed). |
There was a problem hiding this comment.
Add a newline above if you want to separate these two paragraph
|
/run-e2e-test |
2 similar comments
|
/run-e2e-test |
|
/run-e2e-test |
weekface
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
affinitysettings and change thenodeSelectormeaningConfigurationsubject for docoperation-guide.mdWhat is changed and how it works?
Changed the
TidbClusterstruct , add the following fieldto
PDSpec/TiKVSpec/TiDBSpecand removeNodeSelectorRequired.tidb-operator directly assigns the above
Affinityfield to pd/tidb/tikv's StatefulSet,and then done.Check List
Tests
Code changes
The following files were changed:
Side effects
Because this PR changed the
TidbcClusterCRD, so it can not compatible with previous versions.Does this PR introduce a user-facing change?: