Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add release-note to pull_request_template.md #490

Merged
merged 3 commits into from
May 15, 2019
Merged

add release-note to pull_request_template.md #490

merged 3 commits into from
May 15, 2019

Conversation

weekface
Copy link
Contributor

What problem does this PR solve?

  • add the release-note section to pull request template as kubernetes does

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

tennix
tennix approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

@onlymellb @xiaojingchen @aylei @cofyc ptal

@weekface weekface merged commit d5deeb8 into pingcap:master May 15, 2019
@weekface weekface deleted the release-note branch May 15, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix approved these changes

@cofyc cofyc cofyc approved these changes

@aylei aylei Awaiting requested review from aylei

@onlymellb onlymellb Awaiting requested review from onlymellb

@xiaojingchen xiaojingchen Awaiting requested review from xiaojingchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weekface @cofyc @tennix