Gke terraform and guide #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should have a firewall rule to allow SSH to the GKE nodes from the bastion. This can use the "bastion" tag |
tennix
requested changes
May 15, 2019
aylei
reviewed
May 15, 2019
gregwebs
reviewed
May 15, 2019
jlerche
force-pushed
the
gke_terraform_and_guide
branch
from
05a6eda to
34ee7a5
Compare
gregwebs
reviewed
May 15, 2019
gregwebs
reviewed
May 15, 2019
jlerche
force-pushed
the
gke_terraform_and_guide
branch
from
042a114 to
857c66a
Compare
|
@DanielZhangQD deployed a testing cluster on GCP with this PR, the tikv pods cannot start due to small max-open-file descriptors. Besides, it's the default local ssd has poor performance without installing Linux Guest Environment |
tennix
reviewed
May 21, 2019
jlerche
force-pushed
the
gke_terraform_and_guide
branch
from
a68bdfa to
2b145ab
Compare
|
Can you mention the startup-script in the GKE related docs? Maybe move it to the manifests folder? |
gregwebs
reviewed
May 21, 2019
gregwebs
reviewed
May 21, 2019
… across zones in a regional cluster
|
Per slack conversation with @gregwebs, startup-script related docs changes will be done in a separate PR. |
gregwebs
reviewed
May 22, 2019
|
|
||
| Currently, there are not too many parameters exposed to be customized. However, you can modify `templates/tidb-cluster-values.yaml.tpl` before deploying. If you modify it after the cluster is created and then run `terraform apply`, it will not take effect unless the pod(s) is manually deleted. | ||
|
|
||
| ### Customizing node pools |
There was a problem hiding this comment.
Suggested change
| ### Customizing node pools | |
| ### Removing unused instances |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes #446
What is changed and how it works?
Adds GCP terraform deploy and README
Check List
Tests
Code changes
Several changes were made since the last review: