Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvc_cleaner: reclaim ticdc pvc #4944

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mahjonp
Copy link
Contributor

@mahjonp mahjonp commented Mar 28, 2023

What problem does this PR solve?

fix #4943

What is changed and how does it work?

Append ticdc into the component selection lists.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Signed-off-by: mahjonp <junpeng.man@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #4944 (5bab6a2) into master (0f7ae20) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4944      +/-   ##
==========================================
- Coverage   57.01%   57.00%   -0.01%     
==========================================
  Files         243      243              
  Lines       27481    27481              
==========================================
- Hits        15667    15665       -2     
- Misses      10284    10285       +1     
- Partials     1530     1531       +1     
Flag Coverage Δ
unittest 57.00% <100.00%> (-0.01%) ⬇️

@mahjonp
Copy link
Contributor Author

mahjonp commented Mar 29, 2023

/test pull-e2e-kind

@csuzhangxc
Copy link
Member

@grovecai PTAL

@mahjonp
Copy link
Contributor Author

mahjonp commented Mar 30, 2023

/test pull-e2e-kind

@mahjonp
Copy link
Contributor Author

mahjonp commented Apr 3, 2023

/test pull-e2e-kind-across-kubernetes
/test pull-e2e-kind-basic

@mahjonp
Copy link
Contributor Author

mahjonp commented Apr 4, 2023

/test pull-e2e-kind-across-kubernetes

2 similar comments
@mahjonp
Copy link
Contributor Author

mahjonp commented Apr 4, 2023

/test pull-e2e-kind-across-kubernetes

@mahjonp
Copy link
Contributor Author

mahjonp commented Apr 7, 2023

/test pull-e2e-kind-across-kubernetes

@csuzhangxc csuzhangxc requested a review from grovecai May 29, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ticdc: pvc_cleaner doesn't reclaim PVC after ticdc scaled in
4 participants