Support adding additional pod annotations for PD/TiKV/TiDB #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlymellb
reviewed
May 17, 2019
|
onlymellb
reviewed
May 20, 2019
OK. I've add generated deepcopy file, andd add a issue for tracing e2e cases.#505. |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
add a release note like this pr does: #479 |
LinuxGit
changed the title
|
/run-e2e-tests |
OK. I've refined the PR description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support adding additional pod annotations for PD/TiKV/TiDB.
We could add pod annotation
fluentbit.io/parser: pingcap_logfor PD/TiKV/TiDB pod, so fluentbit knows that the pod log should be processed using the pre-defined parser calledpingcap_log.refer: https://docs.fluentbit.io/manual/filter/kubernetes#kubernetes-annotations
What is changed and how it works?
At the server side,
Annotationsfield was added in TidbClusterSpec's Pod Spec (PDSpec, TiKVSpec and TiDBSpec). If Annotations field is not empty, the PD/TiKV/TiDB statefulset will add the annotation to PodTemplateSpec's Annotations field.At the client side, you could add additional annotations in Helm values file
charts/tidb-cluster/values.yaml.Check List
Tests
The Unit and E2E test cases will be tracked in issue #505.
Code changes
Does this PR introduce a user-facing change?: