Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document about PD configuration management issue #504

Merged
merged 2 commits into from
May 21, 2019
Merged

Document about PD configuration management issue #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9912d98
Document about PD configuration issue
aylei May 20, 2019
17a6905
Merge branch 'master' into issue-487
weekface May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/operation-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ For minor version upgrade, updating the `image` should be enough. When TiDB majo

Since `v1.0.0`, TiDB operator can perform rolling-update on configuration updates. This feature is disabled by default in favor of backward compatibility, you can enable it by setting `enableConfigMapRollout` to `true` in your helm values file.

> **Note**: currently, changing PD's `scheduler` and `replication` configurations(`maxStoreDownTime` and `maxReplicas` in `values.yaml`, and all the configuration key under `[scheduler]` and `[replication]` section if you override the pd config file) after cluster creation has no effect. You have to configure these variables via `pd-ctl` after the cluster creation, see: [pd-ctl](https://pingcap.com/docs/dev/reference/tools/pd-control/)

> WARN: changing this variable against a running cluster will trigger an rolling-update of PD/TiKV/TiDB pods even if there's no configuration change.

## Destroy TiDB cluster
Expand Down
4 changes: 4 additions & 0 deletions images/tidb-operator-e2e/tidb-cluster-values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,13 @@ pd:

# maxStoreDownTime is how long a store will be considered `down` when disconnected
# if a store is considered `down`, the regions will be migrated to other stores
# Note: changing this value after cluster creation has no effect, instead, you have to configure this using pd-ctl
# see https://pingcap.com/docs/dev/reference/tools/pd-control/
maxStoreDownTime: 1h
# maxReplicas is the number of replicas for each region
# Note: same as maxStoreDownTime, change of this value should be made using pd-ctl after cluster creation
maxReplicas: 3

resources:
limits: {}
# cpu: 8000m
Expand Down