pause-upgrade stability test #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
weekface
reviewed
May 27, 2019
| @@ -376,6 +376,15 @@ func (oa *operatorActions) DeployOperator(info *OperatorConfig) error { | |||
| return fmt.Errorf("failed to deploy operator: %v, %s", err, string(res)) | |||
| } | |||
|
|
|||
| // delete statefulset update webhook and configuration | |||
| cmd = fmt.Sprintf("kubectl delete -f %s/webhook.yaml", oa.manifestPath(info.Tag)) | |||
There was a problem hiding this comment.
why move the cleaner to DeployOperator?
There was a problem hiding this comment.
manifests dir will only exist after checkouttag in stability test
|
/run-e2e-tests |
weekface
approved these changes
May 27, 2019
xiaojingchen
approved these changes
May 27, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* en: tidb cluster offline installation Signed-off-by: lucklove <gnu.crazier@gmail.com> * Apply suggestions from code review Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Does this PR introduce a user-facing change?: