add storeLabels setting #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
reviewed
May 28, 2019
tennix
reviewed
Jun 28, 2019
| @@ -192,6 +193,14 @@ tikv: | |||
| # effect: "NoSchedule" | |||
| annotations: {} | |||
|
|
|||
| ## storeLabels is used to define store label keys | |||
There was a problem hiding this comment.
In order to use the location awareness feature of TiKV, users have to label their k8s nodes with the same labels.
| } | ||
| if host, found := ls[apis.LabelHostname]; found { | ||
| labels["host"] = host | ||
| if storeLabel == "host" { |
There was a problem hiding this comment.
Add a TODO note that this needs to be changed when PD supports label key containing slash character.
|
/run-e2e-tests |
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
…/tidb-operator into refine-store-labels
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
approved these changes
Jul 3, 2019
|
@tennix this pr needs another approval |
tennix
approved these changes
Jul 3, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
user must know current storeLabel cannot support contains the slash character.
Related changes
Does this PR introduce a user-facing change?: