deploy/aws: split public and private subnets when using existing vpc #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aylei
suggested changes
May 29, 2019
There was a problem hiding this comment.
Could you move the variable comments to description in favor of document generation?
deploy/aws/README.md
Outdated
| By default, the terraform script will create a new VPC. You can use an existing VPC by setting `create_vpc` to `false` and specify your existing VPC id and subnet ids to `vpc_id` and `subnets` variables. | ||
| By default, the terraform script will create a new VPC. You can use an existing VPC by setting `create_vpc` to `false` and specify your existing VPC id and subnet ids to `vpc_id`, `private_subnet_ids` and `public_subnet_ids` variables. | ||
|
|
||
| **Note:** Reusing VPC and subnets of an existing EKS cluster is not supported yet due to limitations of AWS and Terraform, so only change this option if you have to use a manually created VPC. |
| variable "private_subnet_ids" { | ||
| description = "private subnet id list" | ||
| type = "list" | ||
| default = ["subnet-899e79f3", "subnet-a72d80cf", "subnet-a76d34ea"] |
There was a problem hiding this comment.
These defaults are wired and seems to be environment dependent
There was a problem hiding this comment.
These are samples and should be changed to user's values if they need to use existing ones, by default (with create_vpc=true) these values are ignored.
tennix
reviewed
May 29, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add link achor check * fix dead anchors * reorder * fix anchors * fix an anchor according to hailong's suggestion Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This should close #514
What is changed and how it works?
subnetstoprivate_subnet_idsandpublic_subnet_ids, to correctly put resources into different network.cluster_nameto helm release name, making pod names uniqueCheck List
Tests
Code changes
Side effects
terraformwith new code to manage an cluster deployed by old versions.Related changes
Does this PR introduce a user-facing change?: