docs: note helm versions in deployment docs #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to note all these helm versions? https://github.com/pingcap/tidb-operator/search?l=Markdown&q=helm |
My point is that if it's not tested, then the answer is no. And if it's tested and v3.x not work at all, then the answer is yes. (Of course we should test these cases in the end) In the case of this pr, the v3.x not work, so we need to document it. |
|
Yes, I think all places when mentioning helm versions should be noted. |
tennix
requested changes
Jun 5, 2019
|
Helm 3.0 is a huge refactor. I don't think we can run with helm v3.0 in any of the environment without modification of the charts, so all the documents need to be updated. |
weekface
approved these changes
Jun 6, 2019
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* Changed warning message about deleting PVs * Changed "backupTemple" to "backupTemplate" in several files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #552
What is changed and how it works?
helmv3.0.0+ are not supported yet.Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: