stability-test: stop kube-proxy case #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
force-pushed
the
kube-proxy-case
branch
4 times, most recently
from
684e943
to
8d47dd4
Compare
|
/run-e2e-tests |
cofyc
requested review from
onlymellb,
xiaojingchen,
qiffang and
weekface
and removed request for
onlymellb and
xiaojingchen
cofyc
commented
Jun 6, 2019
tests/actions.go
Outdated
| @@ -96,15 +96,14 @@ func NewOperatorActions(cli versioned.Interface, | |||
| const ( | |||
| DefaultPollTimeout time.Duration = 10 * time.Minute | |||
| DefaultPollInterval time.Duration = 1 * time.Minute | |||
| BackupAndRestorePollTimeOut time.Duration = 30 * time.Minute | |||
| BackupAndRestorePollTimeOut time.Duration = 60 * time.Minute | |||
There was a problem hiding this comment.
In cluster 3, it takes 40+ minutes to complete.
There was a problem hiding this comment.
reverted, I adjusted blockwrite to test in cluster 3
|
/run-e2e-tests |
cofyc
changed the title
cofyc
changed the title
cofyc
commented
Jun 13, 2019
tests/failover.go
Outdated
| @@ -360,7 +360,7 @@ func (oa *operatorActions) tikvFailover(pod *corev1.Pod, tc *v1alpha1.TidbCluste | |||
| healthCount++ | |||
| } | |||
| } | |||
| if tc.Status.TiKV.Synced && healthCount == int(tc.Spec.TiKV.Replicas) { | |||
| if tc.Status.TiKV.Synced && healthCount >= int(tc.Spec.TiKV.Replicas) { | |||
There was a problem hiding this comment.
This is suggested by @weekface to fix a race condition on TiKV failover check.
cofyc
commented
Jun 13, 2019
| glog.Fatalf("update kube-proxy daemonset failed, err: %v", err) | ||
| } | ||
|
|
||
| mgr := manager.NewManager() |
There was a problem hiding this comment.
This cleanup code is copied from #503.
|
/run-e2e-tests |
This reverts commit d92df33.
|
/run-e2e-tests |
weekface
approved these changes
Jun 13, 2019
xiaojingchen
approved these changes
Jun 13, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add stop/start kube-proxy stability test case.
This replaces #503.
What is changed and how it works?
Check List
Tests
Stability test
Does this PR introduce a user-facing change?: