add operator upgrade case #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
force-pushed
the
upgrade-operator
branch
from
34a298f
to
863aad2
Compare
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
xiaojingchen
approved these changes
Jun 21, 2019
|
@cofyc PTAL |
cofyc
reviewed
Jun 21, 2019
| WebhookURL string | ||
| Channel string | ||
| WebhookURL string | ||
| SuccessCount int |
There was a problem hiding this comment.
It is used at these postions:
https://github.com/pingcap/tidb-operator/pull/579/files#diff-2ef72aa70c90226cd8aac8a436f9bff9R150
https://github.com/pingcap/tidb-operator/pull/579/files#diff-8f8eafaeec65b7926966885b1c103ca8R58
https://github.com/pingcap/tidb-operator/pull/579/files#diff-8f8eafaeec65b7926966885b1c103ca8R300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: