Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate CRD files #5954

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Regenerate CRD files #5954

merged 1 commit into from
Nov 25, 2024

Conversation

ideascf
Copy link
Contributor

@ideascf ideascf commented Nov 25, 2024

What problem does this PR solve?

Regenerate manifest files

What is changed and how does it work?

Run command make generate crd api-references

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Nov 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-25 02:58:21.691799705 +0000 UTC m=+432489.311454220: ☑️ agreed by csuzhangxc.

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-basic

@csuzhangxc
Copy link
Member

/cherry-pick release-1.6

@ti-chi-bot
Copy link
Member

@csuzhangxc: once the present PR merges, I will cherry-pick it on top of release-1.6 in the new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.29%. Comparing base (a16b2e8) to head (c30b6cd).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5954      +/-   ##
==========================================
+ Coverage   57.19%   59.29%   +2.09%     
==========================================
  Files         259      262       +3     
  Lines       33233    45423   +12190     
==========================================
+ Hits        19008    26933    +7925     
- Misses      12291    16472    +4181     
- Partials     1934     2018      +84     
Flag Coverage Δ
e2e 20.99% <ø> (?)
unittest 57.04% <ø> (-0.16%) ⬇️
---- 🚨 Try these New Features:

@csuzhangxc csuzhangxc merged commit f648aab into pingcap:master Nov 25, 2024
7 checks passed
@ti-chi-bot
Copy link
Member

@csuzhangxc: new pull request created to branch release-1.6: #5955.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2024
10 tasks
@ideascf ideascf deleted the regen-crd branch November 25, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants