Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-kubernetes-tutorial.md #622

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

thecodeassassin
Copy link
Contributor

Fixed typo in docs

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has CI related scripts change
  • Has documents change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:


@sre-bot
Copy link
Contributor

sre-bot commented Jul 2, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gregwebs
Copy link
Contributor

gregwebs commented Jul 2, 2019

/ok-to-test

@gregwebs
Copy link
Contributor

gregwebs commented Jul 2, 2019

Thanks @thecodeassassin
BTW, you might try our terraform based setup where we have been focusing our efforts lately.

@thecodeassassin
Copy link
Contributor Author

@gregwebs thanks for the tip. Does it also show how to span tidb over multiple (geographic) clusters?

@gregwebs
Copy link
Contributor

gregwebs commented Jul 2, 2019

Our operator is designed to run on a single K8s cluster. So you would need to have a federated K8s cluster . You can look at using tidb-ansible for deploying across datacenters.

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface weekface merged commit cca0d2a into pingcap:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants