TiKV upgrade bug fix #626
Merged
TiKV upgrade bug fix #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-tests |
weekface
reviewed
Jul 3, 2019
tests/actions.go
Outdated
| if len(schedulers) == 0 { | ||
| return true, nil | ||
| } | ||
| glog.Errorf("schedulers: %v is not empty") |
There was a problem hiding this comment.
Suggested change
| glog.Errorf("schedulers: %v is not empty") | |
| glog.Errorf("schedulers: %v is not empty", schedulers) |
tests/pkg/webhook/pods.go
Outdated
| @@ -24,42 +23,6 @@ var ( | |||
| kvLeaderMap map[string]map[string]int | |||
|
/run-e2e-tests |
|
/run-e2e-tests |
3 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
previously approved these changes
Jul 4, 2019
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
2 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
approved these changes
Jul 9, 2019
|
@shuijing198799 PTAL |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
this pr fixes: #599
Check List
Tests
Code changes
Side effects
Does this PR introduce a user-facing change?: