Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support force upgrade when pd cluster is unavailable #631

Merged
merged 5 commits into from
Jul 8, 2019
Merged

support force upgrade when pd cluster is unavailable #631

merged 5 commits into from
Jul 8, 2019

Conversation

DanielZhangQD
Copy link
Contributor

@DanielZhangQD DanielZhangQD commented Jul 4, 2019 •
edited
Loading

What problem does this PR solve?

close #609

What is changed and how does it work?

Support force upgrade if PD cluster is unavailable

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
    • PD cluster image pull backoff during the creation
    • PD cluster pending due to affinity setting during the creation
    • PD cluster is unavailable after creation
    • PD cluster is running normally
    • PD cluster only has 1 replica

Code changes

  • Has Go code change
  • Has documents change

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support force upgrade when PD cluster is unavailable.
To enable force upgrade:
kubectl annotate --overwrite tc ${releaseName} -n ${namespace} tidb.pingcap.com/force-upgrade=true
To disable force upgrade:
kubectl annotate tc ${releaseName} -n ${namespace} tidb.pingcap.com/force-upgrade-
Note: Force upgrade must be disabled when PD cluster is recovered.

@DanielZhangQD DanielZhangQD added area/doc type/bug Something isn't working labels Jul 4, 2019
@DanielZhangQD
Copy link
Contributor Author

/run-e2e-tests

weekface
weekface reviewed Jul 4, 2019
View reviewed changes
pkg/label/label.go Outdated Show resolved Hide resolved
pkg/manager/member/pd_member_manager.go Outdated Show resolved Hide resolved
@weekface
Copy link
Contributor

weekface commented Jul 4, 2019

This pr needs a user-facing change(release note).

@DanielZhangQD @weekface
Apply suggestions from code review
0e5c061 
Co-Authored-By: weekface <weekface@gmail.com>
weekface
weekface reviewed Jul 4, 2019
View reviewed changes
pkg/manager/member/utils.go Outdated Show resolved Hide resolved
pkg/manager/member/pd_member_manager_test.go Outdated Show resolved Hide resolved
@DanielZhangQD
Copy link
Contributor Author

/run-e2e-tests

@DanielZhangQD DanielZhangQD mentioned this pull request Jul 5, 2019
Closed
@tennix tennix mentioned this pull request Jul 5, 2019
Merged
@xiaojingchen
Copy link
Contributor

/run-e2e-tests

2 similar comments
@weekface
Copy link
Contributor

weekface commented Jul 5, 2019

/run-e2e-tests

@weekface
Copy link
Contributor

weekface commented Jul 5, 2019

/run-e2e-tests

@DanielZhangQD
Copy link
Contributor Author

/run-e2e-tests

1 similar comment
@DanielZhangQD
Copy link
Contributor Author

/run-e2e-tests

@DanielZhangQD DanielZhangQD merged commit ed45eb6 into pingcap:master Jul 8, 2019
@DanielZhangQD DanielZhangQD deleted the force-upgrade branch July 8, 2019 08:03
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@ran-huang @lilin90
en, zh: update wording to include elastic scheduling (#631)
05dc932 
* update wording to include elastic scheduling

Signed-off-by: Ran <huangran@pingcap.com>

* Update zh/enable-tidb-cluster-auto-scaling.md

Co-authored-by: Lilian Lee <lilin@pingcap.com>

Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaojingchen xiaojingchen xiaojingchen approved these changes

@weekface weekface weekface approved these changes

@tennix tennix Awaiting requested review from tennix

Assignees
No one assigned
Labels
area/doc type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fail to upgrade pd
3 participants
@DanielZhangQD @weekface @xiaojingchen