Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove storeLabels #663

Merged
merged 6 commits into from
Jul 18, 2019
Merged

Remove storeLabels #663

merged 6 commits into from
Jul 18, 2019

Conversation

xiaojingchen
Copy link
Contributor

@xiaojingchen xiaojingchen commented Jul 17, 2019 •
edited
Loading

What problem does this PR solve?

  • remove tikv.storeLabels setting.
  • change the way to set TiKV store labels，operator gets location labels from PD.

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)

Code changes

  • Has Go code change
  • Has documents change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

ACTION REQUIRED: `tikv.storeLabels` was remove from values.yaml. Instead, you can set it with `location-labels` in `pd.config` directly

@xiaojingchen xiaojingchen changed the title Remove store labels Remove storeLabels Jul 17, 2019
@xiaojingchen
Copy link
Contributor Author

/run-e2e-tests

@weekface weekface added this to the v1.0.0 milestone Jul 18, 2019
@xiaojingchen xiaojingchen requested review from tennix and aylei July 18, 2019 08:27
aylei
aylei approved these changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaojingchen xiaojingchen merged commit 825705b into pingcap:master Jul 18, 2019
@xiaojingchen xiaojingchen mentioned this pull request Jul 18, 2019
Merged
5 tasks
weekface pushed a commit that referenced this pull request Jul 29, 2019
@xiaojingchen @weekface
Remove storeLabels (#663)
152c65c 
* remove storeLabels

(cherry picked from commit 825705b)
yahonda pushed a commit that referenced this pull request Dec 27, 2021
@ran-huang
en: simplify deployment on aws eks (#663)
79295f8 
Signed-off-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aylei aylei aylei approved these changes

@weekface weekface weekface approved these changes

@tennix tennix Awaiting requested review from tennix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaojingchen @weekface @aylei