Stability cases: stop kubelet and etcd #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pv data safe
weekface
commented
Jul 18, 2019
| @@ -173,7 +173,7 @@ func (oa *operatorActions) CheckFailoverPending(info *TidbClusterConfig, node st | |||
| if _, exist := affectedPods[failureStore.PodName]; exist { | |||
| err := fmt.Errorf("cluster: [%s] the tikv store[%s] should be mark failure after %s", info.FullName(), failureStore.PodName, deadline.Format(time.RFC3339)) | |||
| glog.Errorf(err.Error()) | |||
| return false, err | |||
| return false, nil | |||
There was a problem hiding this comment.
There may have been a failover before.
There was a problem hiding this comment.
should this be a comment in the code?
weekface
commented
Jul 18, 2019
| @@ -950,7 +1020,8 @@ func (oa *operatorActions) CheckUpgrade(ctx context.Context, info *TidbClusterCo | |||
| } | |||
| glog.V(4).Infof("index:%d,schedulers:%v,error:%v", i, schedulers, err) | |||
| if len(schedulers) > 1 { | |||
| return true, fmt.Errorf("there are too many evict leader schedulers: %v", schedulers) | |||
| glog.Errorf("there are too many evict leader schedulers: %v", schedulers) | |||
| return false, nil | |||
There was a problem hiding this comment.
There may be two schedulers at the same time
|
/run-e2e-tests |
|
/run-e2e-tests |
xiaojingchen
previously approved these changes
Jul 18, 2019
|
/run-e2e-tests |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
xiaojingchen
approved these changes
Jul 25, 2019
weekface
added a commit
that referenced
this pull request
Jul 29, 2019
(cherry picked from commit d9851bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: