Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on automatic failover #667

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Conversation

weekface
Copy link
Contributor

@weekface weekface commented Jul 18, 2019

What problem does this PR solve?

Automatic failover has been verified by a large number of stability tests, so we should turn it on by default.

What is changed and how does it work?

Check List

Tests

  • No code

Code changes

  • Has Helm charts change
  • Has Go code change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

turn on automatic failover feature by default

@weekface weekface added this to the v1.0.0 milestone Jul 18, 2019
@weekface
Copy link
Contributor Author

/run-e2e-tests

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weekface
Copy link
Contributor Author

/run-e2e-tests

Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor

cofyc commented Jul 22, 2019

/run-e2e-tests

@weekface weekface merged commit a98f437 into pingcap:master Jul 22, 2019
@weekface weekface deleted the automitic-failover branch July 22, 2019 11:14
weekface added a commit that referenced this pull request Jul 29, 2019
(cherry picked from commit a98f437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants