Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git remote add upstream using https #690

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Conversation

shonge
Copy link
Member

@shonge shonge commented Jul 24, 2019

What problem does this PR solve?

#689

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has documents change

Side effects

NONE

Related changes

NONE

Does this PR introduce a user-facing change?:

NONE


@sre-bot
Copy link
Contributor

sre-bot commented Jul 24, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@shonge shonge changed the title git remote add upstream useing https git remote add upstream using https Jul 24, 2019
Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cofyc
Copy link
Contributor

cofyc commented Jul 24, 2019

/run-e2e-tests

@weekface weekface merged commit 0333f97 into pingcap:master Jul 25, 2019
weekface pushed a commit that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants