Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: inject a failure by pod annotation #716

Merged
merged 6 commits into from
Aug 7, 2019

Conversation

gregwebs
Copy link
Contributor

This can be useful for testing scheduling failures.
You can for example add it to monitor-deployment
along with changing the scheduler to the custom scheduler.

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    I tested as mentioned in the PR. I observed that no other pods had failed scheduling, including after deploying a second TiDB cluster.

Code changes

  • Has Go code change

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

This can be useful for testing scheduling failures.
You can for example add it to monitor-deployment
along with changing the scheduler to the custom scheduler.
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
tennix
tennix previously approved these changes Aug 2, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/label/label.go Outdated Show resolved Hide resolved
Co-Authored-By: Tennix <tennix@users.noreply.github.com>
@gregwebs
Copy link
Contributor Author

gregwebs commented Aug 2, 2019

/run-e2e-tests

1 similar comment
@weekface
Copy link
Contributor

weekface commented Aug 2, 2019

/run-e2e-tests

Copy link
Contributor

@weekface weekface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregwebs gregwebs changed the title scheduler: inject a failure by pod label scheduler: inject a failure by pod annotation Aug 2, 2019
@gregwebs
Copy link
Contributor Author

gregwebs commented Aug 7, 2019

/run-e2e-tests

@gregwebs gregwebs merged commit 46c7b76 into master Aug 7, 2019
@gregwebs gregwebs deleted the scheduler/inject-failure branch August 7, 2019 21:00
@sre-bot
Copy link
Contributor

sre-bot commented Aug 7, 2019

cherry pick to release-1.0 in PR #739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants