tests: change cluster clean logic #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojingchen
changed the title
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
|
/run-e2e-tests |
|
/run-e2e-tests |
weekface
approved these changes
Aug 1, 2019
|
@cofyc @shuijing198799 PTAL |
|
/run-e2e-tests |
|
cherry pick to release-1.0 in PR #731 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The problem is that the e2e test was blocked when e2e was deleting PVCs.
Because then the Jobs have not deleted cause the PVC that was bound to Job is blocking in
Terminatingstatus.What is changed and how does it work?
change e2e test 's delete cluster logic, make delete jobs before the delete pvc to avoid block.
Check List
Tests
Code changes
Does this PR introduce a user-facing change?: