Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider versions constraint for GCP and Aliyun and support values file customization for tidb-operator and tidb-cluster #959

Merged
merged 4 commits into from
Sep 29, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions deploy/aliyun/versions.tf
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@

terraform {
required_version = ">= 0.12"
required_providers {
alicloud = "~> 1.56"
external = "~> 1.2"
helm = "~> 0.10"
null = "~> 2.1"
template = "~> 2.1"
}
}
2 changes: 1 addition & 1 deletion deploy/gcp/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module "tidb-operator" {
kubeconfig_path = local.kubeconfig
tidb_operator_version = var.tidb_operator_version
maintenance_window_start_time = var.maintenance_window_start_time
operator_helm_values = var.operator_helm_values
operator_helm_values = var.operator_helm_values == "" ? var.operator_helm_values_file == "" ? "" : file(var.operator_helm_values_file) : var.operator_helm_values
}

module "bastion" {
Expand Down
2 changes: 1 addition & 1 deletion deploy/gcp/tidbclusters.tf
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ module "default-tidb-cluster" {
tidb_node_count = var.tidb_count
monitor_node_count = var.monitor_count
tikv_local_ssd_count = var.tikv_local_ssd_count
override_values = var.override_values
override_values = var.override_values == "" ? var.override_values_file == "" ? "" : file(var.override_values_file) : var.override_values
}
9 changes: 9 additions & 0 deletions deploy/gcp/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ variable "operator_helm_values" {
default = ""
}

variable "operator_helm_values_file" {
description = "The helm values file for TiDB Operator, path is relative to current working dir"
default = ""
}

variable "create_vpc" {
default = true
}
Expand Down Expand Up @@ -129,3 +134,7 @@ variable "override_values" {
description = "YAML formatted values that will be passed in to the tidb-cluster helm release"
default = ""
}
variable "override_values_file" {
description = "The helm values file for TiDB Cluster, path is relative to current working dir"
default = ""
}
7 changes: 7 additions & 0 deletions deploy/gcp/versions.tf
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@

terraform {
required_version = ">= 0.12"
required_providers {
google = "~> 2.16"
google-beta = "~> 2.16"
external = "~> 1.2"
helm = "~> 0.10"
null = "~> 2.1"
}
}