Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the default externalTrafficPolicy to be Local for TiDB service (#947) #960

Merged
merged 1 commit into from
Sep 29, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 27, 2019

cherry-pick #947 to release-1.0


What problem does this PR solve?

#879

What is changed and how does it work?

The default externalTrafficPolicy is now set to be Local

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. Deploy to AWS from /tidb-operator/deploy/aws out-of-box
  2. Run kubectl describe service my-cluster-tidb -n my-cluster and verify the value of externalTrafficPolicy.

Code changes

  • Has Helm charts change

Side effects

  • Breaking backward compatibility

Related changes

  • N/A

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei aylei merged commit 90697df into pingcap:release-1.0 Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants