do not limit failover count when maxFailoverCount not greater than 0 (#977) #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-e2e-in-kind |
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
…nfig (#978) * zh: remove the get started section of using tidbmonitor * zh: move monitor-a-tidb-cluster under reference * zh: merge monitor-using-tidbmonitor into monitor-a-tidb-cluster * zh: add contents about spec.prometheus.config * zh: clearer * zh: fix deadlinks * zh: address comments * zh: fix TOC * zh: fix links * Update zh/monitor-a-tidb-cluster.md Co-authored-by: Ran <huangran@pingcap.com> * zh: fix heading * zh: address comments * zh: address comments * zh: fix link * zh: address comments * Update zh/monitor-a-tidb-cluster.md Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> * Update zh/monitor-a-tidb-cluster.md Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Ran <huangran@pingcap.com> Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #977 to release-1.0
What problem does this PR solve?
#965, added a
maxFailoverCountlimit to TiKV, set it to3invalues.yaml. But the oldTidbClusterobject is0, it can't failover after upgrade the tidb-operator.To ensure compatibility, we should keep it no failover count limit if
maxFailoverCountis0.What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: