-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diff: can use multiple columns to split chunks #130
diff: can use multiple columns to split chunks #130
Conversation
CI was broken |
good job! |
@kennytm PTAL |
LGTM |
for _, indexColumn := range index.Columns { | ||
for _, column := range tableInfo.Columns { | ||
if column.Name.O == indexColumn.Name.O { | ||
indexColumns = append(indexColumns, column) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible one column appended multi times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, a index can only contain unique column
This reverts commit eefbad2.
@csuzhangxc PTAL again |
LGTM. but you need to resolve the conflict now. |
thanks @csuzhangxc |
* sync_diff_inspector: fix a misleading regex example in config.toml (#141) * update pkg about database (#142) * diff: add database name and table name router (#172) * simplify the if/else logic (#179) refactor to simplify the if/else logic * diff: can use multiple columns to split chunks (#130) * simplify the if/else logic (#191)
What problem does this PR solve?
What is changed and how it works?
for example:
we can get the lower_bound and upper_bound as chunk's range.
will split to these chunks when chunk size is 1:
Check List
Tests
Related changes