Skip to content

Commit

Permalink
udpate some comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lcwangchao committed Feb 7, 2024
1 parent 7f6aafe commit 003c23b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/planner/core/rule_partition_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ type partitionTable interface {
func generateHashPartitionExpr(ctx sessionctx.Context, pi *model.PartitionInfo, columns []*expression.Column, names types.NameSlice) (expression.Expression, error) {
schema := expression.NewSchema(columns...)
// Increase the PlanID to make sure some tests will pass. The old implementation to rewrite AST builds a `TableDual`
// that causes the `PlanID` increases, and many test cases hardcoded the output plan in the expected result.
// that causes the `PlanID` increases, and many test cases hardcoded the output plan ID in the expected result.
// Considering the new `ParseSimpleExpr` does not do the same thing and to make the test pass,
// we have to increase the `PlanID` here. But it is safe to remove this line without introducing any bug.
// TODO: remove this line after fixing the test cases.
Expand Down Expand Up @@ -1055,7 +1055,7 @@ func makePartitionByFnCol(sctx sessionctx.Context, columns []*expression.Column,
monotonous := monotoneModeInvalid
schema := expression.NewSchema(columns...)
// Increase the PlanID to make sure some tests will pass. The old implementation to rewrite AST builds a `TableDual`
// that causes the `PlanID` increases, and many test cases hardcoded the output plan in the expected result.
// that causes the `PlanID` increases, and many test cases hardcoded the output plan ID in the expected result.
// Considering the new `ParseSimpleExpr` does not do the same thing and to make the test pass,
// we have to increase the `PlanID` here. But it is safe to remove this line without introducing any bug.
// TODO: remove this line after fixing the test cases.
Expand Down

0 comments on commit 003c23b

Please sign in to comment.