planner: disallow split clustered index with SPLIT TABLE .. INDEX

pingcap · Oct 7, 2023 · 98ed2d6 · 98ed2d6
1 parent 413a58f
commit 98ed2d6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/executor/test/splittest/split_table_test.go b/executor/test/splittest/split_table_test.go
@@ -163,6 +163,10 @@ func TestClusterIndexSplitTableIntegration(t *testing.T) {
 	tk.MustExec("create table t (a varchar(255), b decimal, c int, primary key (a, b));")
 	errMsg = "[types:1265]Incorrect value: '' for column 'b'"
 	tk.MustGetErrMsg("split table t by ('aaa', '')", errMsg)
+
+	tk.MustExec("drop table t;")
+	tk.MustExec("CREATE TABLE t (`id` varchar(10) NOT NULL, primary key (`id`) CLUSTERED);")
+	tk.MustGetErrCode("split table t index `primary` between (0) and (1000) regions 2;", errno.ErrKeyDoesNotExist)
 }
 
 func TestClusterIndexShowTableRegion(t *testing.T) {

diff --git a/planner/core/planbuilder.go b/planner/core/planbuilder.go
@@ -4596,7 +4596,7 @@ func (b *PlanBuilder) buildSplitRegion(node *ast.SplitRegionStmt) (Plan, error)
 func (b *PlanBuilder) buildSplitIndexRegion(node *ast.SplitRegionStmt) (Plan, error) {
 	tblInfo := node.Table.TableInfo
 	indexInfo := tblInfo.FindIndexByName(node.IndexName.L)
-	if indexInfo == nil {
+	if indexInfo == nil || indexInfo.Primary && tblInfo.IsCommonHandle {
 		return nil, ErrKeyDoesNotExist.GenWithStackByArgs(node.IndexName, tblInfo.Name)
 	}
 	mockTablePlan := LogicalTableDual{}.Init(b.ctx, b.getSelectOffset())