Skip to content

Commit

Permalink
br: fix unit test
Browse files Browse the repository at this point in the history
Signed-off-by: WangLe1321 <wangle1321@163.com>
  • Loading branch information
WangLe1321 authored and ti-chi-bot committed Dec 7, 2022
1 parent 3aeb3b9 commit fd611b3
Showing 1 changed file with 29 additions and 22 deletions.
51 changes: 29 additions & 22 deletions br/pkg/storage/s3_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,32 +314,35 @@ func TestS3Storage(t *testing.T) {
{
name: "no region",
s3: &backuppb.S3{
Region: "",
Endpoint: s.URL,
Bucket: "bucket",
Prefix: "prefix",
Region: "",
Endpoint: s.URL,
Bucket: "bucket",
Prefix: "prefix",
ForcePathStyle: true,
},
errReturn: false,
sendCredential: true,
},
{
name: "wrong region",
s3: &backuppb.S3{
Region: "us-east-2",
Endpoint: s.URL,
Bucket: "bucket",
Prefix: "prefix",
Region: "us-east-2",
Endpoint: s.URL,
Bucket: "bucket",
Prefix: "prefix",
ForcePathStyle: true,
},
errReturn: true,
sendCredential: true,
},
{
name: "right region",
s3: &backuppb.S3{
Region: "us-west-2",
Endpoint: s.URL,
Bucket: "bucket",
Prefix: "prefix",
Region: "us-west-2",
Endpoint: s.URL,
Bucket: "bucket",
Prefix: "prefix",
ForcePathStyle: true,
},
errReturn: false,
sendCredential: true,
Expand All @@ -353,6 +356,7 @@ func TestS3Storage(t *testing.T) {
SecretAccessKey: "cd",
Bucket: "bucket",
Prefix: "prefix",
ForcePathStyle: true,
},
errReturn: false,
sendCredential: true,
Expand All @@ -365,30 +369,33 @@ func TestS3Storage(t *testing.T) {
SecretAccessKey: "cd",
Bucket: "bucket",
Prefix: "prefix",
ForcePathStyle: true,
},
errReturn: false,
sendCredential: true,
},
{
name: "no secret access key",
s3: &backuppb.S3{
Region: "us-west-2",
Endpoint: s.URL,
AccessKey: "ab",
Bucket: "bucket",
Prefix: "prefix",
Region: "us-west-2",
Endpoint: s.URL,
AccessKey: "ab",
Bucket: "bucket",
Prefix: "prefix",
ForcePathStyle: true,
},
errReturn: false,
sendCredential: true,
},
{
name: "no secret access key",
s3: &backuppb.S3{
Region: "us-west-2",
Endpoint: s.URL,
AccessKey: "ab",
Bucket: "bucket",
Prefix: "prefix",
Region: "us-west-2",
Endpoint: s.URL,
AccessKey: "ab",
Bucket: "bucket",
Prefix: "prefix",
ForcePathStyle: true,
},
errReturn: false,
sendCredential: false,
Expand Down

0 comments on commit fd611b3

Please sign in to comment.