Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile fail on Windows #12

Closed
fuxiaohei opened this issue Sep 6, 2015 · 4 comments
Closed

compile fail on Windows #12

fuxiaohei opened this issue Sep 6, 2015 · 4 comments

Comments

@fuxiaohei
Copy link

qq 20150906173942

two questions:

  1. syscall.Dup2() can't works on Windows. There is any plan for Windows support.
  2. it needs iconv.h as cgo library. Is it possible to use pure go codes instead of cgo codes ?

`

@ngaut
Copy link
Member

ngaut commented Sep 6, 2015

Could you fix this issue ?
Currently we are using Linux and Mac OS X.

@fuxiaohei
Copy link
Author

I make a pull request for log library

ngaut/log#1

It can work on Windows.

But I find that tidb don't use the breaking api log.CrashLog().... so funny.

@ngaut
Copy link
Member

ngaut commented Sep 11, 2015

Does TiDB works on windows now? @fuxiaohei

@fuxiaohei
Copy link
Author

tidb can be compiled and running by using bat script in #130.

thanks a lot. I will test more cases in windows.

If something breaks, I make a new issue.

@ngaut ngaut closed this as completed Sep 22, 2015
lfkdsk pushed a commit to JustProject/tidb that referenced this issue Nov 4, 2019
…n-test

add test aboud pluginEngine join tikv
windtalker pushed a commit to windtalker/tidb that referenced this issue May 13, 2020
* update

* remove useless code

* remove useless code

* update parser

* add test for prefer local join

* use bcj_local

* update go.mod
ti-srebot pushed a commit that referenced this issue Jul 27, 2020
* support batch cop for tiflash

* support batch cop

* support join push down to tiflash

* refine

* change pb

* push join

* fix

* add hint

* refine hint

* add ranges

* fix

* fix

* fix push down

* fix index

* enable distsql for join

* add a session var to disable/enable broadcast join

* fix bug

* fix bug

* tiny fix

* enable cast decimal pushdown to tiflash

* fix

* fix bc join bug

* make broadcast plan stable

* refine code

* fix bug

* basic support for multi table broadcast join

* fix bug

* basic cbo for broadcast join

* improve

* fix bug

* remote useless code

* add tests

* pass unit tests

* refine code

* support execute summary info for broadcast join

* fix bug in explain for broadcast join

* format code

* remove un-needed code

* fix make dev

* address comments

* Hanfei/join merge (#7)

* enable exec details for batch cop

* format code

* fix test

* change tidb_opt_broadcast_join to global vars

* Ban cartesian join to be pushed down to TiFlash (#8)

* merge master (#10)

* merge master

* fix bug

* fix bug

* fix ut

* check session var conflict

* Add perfer local hint for broadcast join (#12)

* update

* remove useless code

* remove useless code

* update parser

* add test for prefer local join

* use bcj_local

* update go.mod

* refine planner

* refine comments

* fix make dev

* fix make dev

* update parser

* address comments

* fix make dev

* disable broadcast join when new collation is enabled

* Update planner/core/exhaust_physical_plans.go

Co-authored-by: Zhuomin(Charming) Liu <lzmhhh123@gmail.com>

* address comments

* fix

* address comments

* fix tests

* address comments

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: 虎 <ichneumon.hu@foxmail.com>
Co-authored-by: Zhuomin(Charming) Liu <lzmhhh123@gmail.com>
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
YuJuncen pushed a commit to YuJuncen/tidb that referenced this issue Apr 23, 2021
rebelice pushed a commit to rebelice/tidb that referenced this issue Jan 6, 2022
lichunzhu added a commit to lichunzhu/tidb that referenced this issue Jan 9, 2022
adjust lightning arguments to increase speed
AilinKid added a commit to AilinKid/tidb that referenced this issue Mar 17, 2022
planner: let scope only be affected when check FDs
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
Co-authored-by: artem_danilov <artem_danilov@airbnb.com>
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
…ngcap#47808) (pingcap#12)

* add backoff and region error check for GetMvccByEncodedKey API

* update client-go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants