Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The retry of physical resolve lock is useless #16306

Closed
youjiali1995 opened this issue Apr 13, 2020 · 0 comments · Fixed by #16413
Closed

The retry of physical resolve lock is useless #16306

youjiali1995 opened this issue Apr 13, 2020 · 0 comments · Fixed by #16413
Assignees
@youjiali1995
Labels
component/GC severity/moderate type/bug The issue is confirmed as a bug.
Milestone
v4.0.0-rc.1

Comments

@youjiali1995
Copy link
Contributor

youjiali1995 commented Apr 13, 2020 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. What did you do?

2. What did you expect to see?

3. What did you see instead?

  1. GC worker doesn't re-register lock observers of dirty stores which causes these stores are always dirty.
  2. GC worker doesn't register lock observers of newly added stores which causes these stores are always dirty.
  3. Can't remove lock observers of cleaned stores.
  4. If there are dirty stores after 3 round physical resolve lock, GC worker won't fall back to legacy procedure which breaks the data safety.

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youjiali1995 youjiali1995

Labels
component/GC severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
v4.0.0-rc.1
Development

Successfully merging a pull request may close this issue.

gc_worker: fix serveral bugs of green gc youjiali1995/tidb
3 participants
@cfzjywxk @youjiali1995 @sre-bot