Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc_worker: fix serveral bugs of green gc (#16413) #16949

Merged
merged 2 commits into from
May 6, 2020
Merged

gc_worker: fix serveral bugs of green gc (#16413) #16949

merged 2 commits into from
May 6, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 30, 2020 •
edited by youjiali1995
Loading

cherry-pick #16413 to release-4.0

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Issue Number: close #16306

Problem Summary:

  1. GC worker doesn't re-register lock observers of dirty stores which causes these stores are always dirty.
  2. GC worker doesn't register lock observers of newly added stores which causes these stores are always dirty.
  3. Can't remove lock observers of cleaned stores.
  4. If there are dirty stores after 3 round physical resolve lock, GC worker won't fall back to legacy procedure which breaks the data safety.

What is changed and how it works?

What's Changed:
It's simple. Please refer to the codes.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

Release note

  • Fix the issue that green GC may leave unresolved locks if there are dirty stores.

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 30, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 30, 2020
Merged
@sre-bot sre-bot added this to the v4.0.0-rc.1 milestone Apr 30, 2020
@youjiali1995
cherry pick pingcap#16413 to release-4.0
f9d15ca 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
jackysp
jackysp reviewed Apr 30, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failed.

@youjiali1995
Merge branch 'release-4.0' of https://github.com/pingcap/tidb into re…
edce6eb 
…lease-4.0-139cb3e99aea

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995
Copy link
Contributor

/run-all-tests

@youjiali1995
Copy link
Contributor

/rebuild

@youjiali1995
Copy link
Contributor

/run-all-tests

@jackysp jackysp merged commit d551807 into pingcap:release-4.0 May 6, 2020
jackysp
jackysp approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youjiali1995 youjiali1995 youjiali1995 approved these changes

@jackysp jackysp jackysp approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@sticnarf sticnarf Awaiting requested review from sticnarf

Assignees

@youjiali1995 youjiali1995

Labels
component/GC type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sre-bot @youjiali1995 @jackysp